• src/sbbs3/download.cpp sbbs.h telgate.cpp xtrn.cpp

    From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Tuesday, November 19, 2024 13:36:12
    https://gitlab.synchro.net/main/sbbs/-/commit/51c917d043aa2d0d85fed78d
    Modified Files:
    src/sbbs3/download.cpp sbbs.h telgate.cpp xtrn.cpp
    Log Message:
    Allow Telnet client to be in binary mode persistently

    Before this change, we'd always request a return to Telnet NVT (turn off binary-TX in both directions) after any file transfer. So although a Telnet session might be negotiated into binary mode shortly after connection
    (e.g., using "telnet -8"), it would be reverted back to NVT mode after any
    file transfer.

    The request to turn off remote binary-TX after executing external programs didn't actually accomplish anything since we track the Telnet option states internally and don't send redundant requests (e.g. the change into a mode
    we're already in). External programs aren't expected to send Telnet requests anyway, so I think this was some holdover from early days of stp/sexyz development.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)